Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web): Slider Field #652

Merged
merged 16 commits into from
Sep 6, 2023
Merged

chore(web): Slider Field #652

merged 16 commits into from
Sep 6, 2023

Conversation

jashanbhullar
Copy link
Contributor

@jashanbhullar jashanbhullar commented Aug 31, 2023 •
edited
Loading

Overview

Sliders field implementation

What I've done

  • Classic code migrated
  • Colors updated
  • Disable state fixed
  • Added property field
  • Tooltip added

What I haven't done

  • NA

How I tested

  • Stories

Which point do I want you to review particularly

  • UI implementation
  • Property field

Memo

  • NA

@netlify
Copy link

netlify bot commented Aug 31, 2023 •
edited
Loading

✅ Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 59f52d1
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f7df061c1b0900087399da
😎 Deploy Preview https://deploy-preview-652--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #652 (59f52d1) into main (6abb7b0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
- Coverage   26.95%   26.94%   -0.01%     
==========================================
  Files        1534     1535       +1     
  Lines      167286   167331      +45     
  Branches     3861     3862       +1     
==========================================
  Hits        45086    45086              
- Misses     121111   121156      +45     
  Partials     1089     1089
Flag Coverage Δ
web 25.25% <0.00%> (-0.01%) ⬇️
web-beta 25.25% <0.00%> (-0.01%) ⬇️
web-classic 25.25% <0.00%> (-0.01%) ⬇️
web-utils 25.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/components/Slider/index.tsx 0.00% <0.00%> (ø)
...rc/beta/components/fields/PropertyFields/index.tsx 0.00% <0.00%> (ø)
...b/src/beta/components/fields/SliderField/index.tsx 0.00% <0.00%> (ø)

@jashanbhullar jashanbhullar marked this pull request as ready for review September 4, 2023 08:04
@jashanbhullar jashanbhullar changed the title feat(web): Slider Field core(web): Slider Field Sep 5, 2023
@jashanbhullar jashanbhullar changed the title core(web): Slider Field chrore(web): Slider Field Sep 5, 2023
@jashanbhullar jashanbhullar changed the title chrore(web): Slider Field chore(web): Slider Field Sep 5, 2023
@jashanbhullar jashanbhullar merged commit f7fe7f6 into main Sep 6, 2023
16 checks passed
@jashanbhullar jashanbhullar deleted the feat/web/slider-field branch September 6, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nina992 nina992 nina992 approved these changes

@KaWaite KaWaite KaWaite approved these changes

Assignees
No one assigned
Labels
web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jashanbhullar @KaWaite @nina992